feat: remove redis ping #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Removes an unnecessary Redis ping call at adapter initialization and cleans up the related test.
- Eliminated the initial
self.client.ping()invocation fromDeprecatedRedisAdapter.__init__ - Removed the
test_init_connect_exctest and its Redis import intests/unit/state/test_redis_adapter.py - TODO reminder to update
CHANGELOG.md
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/corva/cache_adapter.py | Removed initial self.client.ping() call from the constructor |
| tests/unit/state/test_redis_adapter.py | Deleted the test_init_connect_exc function and unused Redis import |
Comments suppressed due to low confidence (1)
src/corva/cache_adapter.py:262
- Update the docstring of
DeprecatedRedisAdapter.__init__to note that it no longer performs a connectivity check at instantiation.
def __init__(
|
@ville what do you think about Copilot suggestions to remove intial self.client.ping() call form the constructor and delete test_init_connect_exc ? |
smoke
approved these changes
Aug 1, 2025
katsanva
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
No need to make extra ping call
Changes
Removed ping call
TODO